Fix junkie/smoker quirks not processing #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
force-pushed
the
fix-junkie-not-processing
branch
from
9e65d91 to
be1b4ce
Compare
Jacquerel
pushed a commit
to tgstation/tgstation
that referenced
this pull request
Jan 26, 2025
## About The Pull Request Several quirks that process have some common checks and patterns: only processing if the mob's stat is conscious or not dead, or not processing if they have certain traits. This refactors quirk processing so those checks are a part of `/datum/quirk` itself, and the quirk will automatically be start/stop being processed by `SSquirks` based on those conditions, by registering signals to re-check if the quirk should be processing or not. This ports said refactor from my downstream PR, Monkestation/Monkestation2.0#4642 (and is unaffected by the bug that Monkestation/Monkestation2.0#4836 fixes, due to additional refactors regarding trait handling) ## Why It's Good For The Game Less repetitive code is always better, and leaves less room for errors. Also, completely stopping the quirk from being processed by `SSquirks` can save a minuscule amount of CPU time. ## Changelog :cl: refactor: Refactored how quirks handle starting/stopping processing. /:cl:
vinylspiders
pushed a commit
to NovaSector/NovaSector
that referenced
this pull request
Jan 28, 2025
## About The Pull Request Several quirks that process have some common checks and patterns: only processing if the mob's stat is conscious or not dead, or not processing if they have certain traits. This refactors quirk processing so those checks are a part of `/datum/quirk` itself, and the quirk will automatically be start/stop being processed by `SSquirks` based on those conditions, by registering signals to re-check if the quirk should be processing or not. This ports said refactor from my downstream PR, Monkestation/Monkestation2.0#4642 (and is unaffected by the bug that Monkestation/Monkestation2.0#4836 fixes, due to additional refactors regarding trait handling) ## Why It's Good For The Game Less repetitive code is always better, and leaves less room for errors. Also, completely stopping the quirk from being processed by `SSquirks` can save a minuscule amount of CPU time. ## Changelog :cl: refactor: Refactored how quirks handle starting/stopping processing. /:cl: # Conflicts: # code/datums/quirks/_quirk.dm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #4834
Why It's Good For The Game
bugfix meow
Changelog
🆑
fix: Fixed the addictions from the Junkie and Smoker quirks curing themselves.
/:cl: